Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions c/c.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ type integer interface {
}

type SizeT = uintptr
type SsizeT = Long
type PtrdiffT = Long

type IntptrT = uintptr
type SsizeT = int

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Add a rationale comment for the int-typed aliases

These three aliases now map to Go int (pointer-width signed) rather than Long, but sit directly beside the detailed platform-sizing comment for Long/Ulong above (lines 42-46). Without a note, a future contributor may "helpfully" revert them to Long to match the surrounding IntmaxT = LongLong styling — reintroducing the 64-bit Windows (LLP64) truncation bug this change fixes.

Consider a one-line comment explaining the intent, e.g.:

// ssize_t/ptrdiff_t/intptr_t are signed pointer-width types;
// map to Go int (pointer-width), NOT C long.
type SsizeT = int
type PtrdiffT = int
type IntptrT = int

type PtrdiffT = int
type IntptrT = int
type UintptrT = uintptr

type Int8T = int8
type Int16T = int16
type Int32T = int32
Expand Down
44 changes: 0 additions & 44 deletions c/openssl/_demo/cbigintdemo/fib.go

This file was deleted.

40 changes: 0 additions & 40 deletions c/openssl/_demo/chmacdemo/hmac.go

This file was deleted.

18 changes: 0 additions & 18 deletions c/openssl/_demo/cmd5demo/md5.go

This file was deleted.

17 changes: 0 additions & 17 deletions c/openssl/_demo/cranddemo/rand.go

This file was deleted.

68 changes: 0 additions & 68 deletions c/openssl/_demo/cshademo/sha.go

This file was deleted.

5 changes: 0 additions & 5 deletions c/openssl/_wrap/openssl.c

This file was deleted.

61 changes: 0 additions & 61 deletions c/openssl/bio.go

This file was deleted.

Loading
Loading