Skip to content

mv c/lua => github.com/llarhub/lua - #63

Merged
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:t
Oct 28, 2026
Merged

xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:t

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FennoAI Review — PR #63: mv c/lua => github.com/llarhub/lua

This is a clean, deletion-only PR that removes the entire c/lua directory (24 files, ~1,897 lines) as part of relocating the Lua C bindings to github.com/llarhub/lua. I ran code-quality, performance, security, and documentation-accuracy passes.

No blocking issues found. The deletion is complete and self-contained:

  • No dangling references — nothing in the repo imports github.com/goplus/lib/c/lua; grep across .go and non-Go files returns no matches, so the build stays green. (Remaining lua hits are unrelated: the word "evaluate" in py/* docs and a historical "Lua Coco" MIT credit in c/neco/_wrap/neco.c.)
  • Module consistency intact — go.mod only declared the module path and Go version; no go.mod/go.sum edits are needed.
  • No orphaned files — the c/lua directory is fully removed with nothing left behind.
  • No stale docs — no README, markdown, config, or workflow file lists or links to the removed package. (The llarhub string in README.md:8 is an unrelated shields.io badge label, not the destination module path.)
  • Security — no secrets were present in the deleted content, and removing code introduces no new trust-boundary or supply-chain exposure within this diff.

Optional, non-blocking: Since moving c/lua to github.com/llarhub/lua is a breaking relocation for any external consumer that imported the old path, consider noting the new import path in the release notes / changelog so downstream users can migrate smoothly.

@xushiwei
xushiwei merged commit c6fca47 into goplus:main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant