Repository navigation
mv c/lua => github.com/llarhub/lua - #63
Merged
Merged
Conversation
There was a problem hiding this comment.
FennoAI Review — PR #63: mv c/lua => github.com/llarhub/lua
This is a clean, deletion-only PR that removes the entire c/lua directory (24 files, ~1,897 lines) as part of relocating the Lua C bindings to github.com/llarhub/lua. I ran code-quality, performance, security, and documentation-accuracy passes.
No blocking issues found. The deletion is complete and self-contained:
- No dangling references — nothing in the repo imports
github.com/goplus/lib/c/lua;grepacross.goand non-Go files returns no matches, so the build stays green. (Remainingluahits are unrelated: the word "evaluate" inpy/*docs and a historical "Lua Coco" MIT credit inc/neco/_wrap/neco.c.) - Module consistency intact —
go.modonly declared the module path and Go version; nogo.mod/go.sumedits are needed. - No orphaned files — the
c/luadirectory is fully removed with nothing left behind. - No stale docs — no README, markdown, config, or workflow file lists or links to the removed package. (The
llarhubstring inREADME.md:8is an unrelated shields.io badge label, not the destination module path.) - Security — no secrets were present in the deleted content, and removing code introduces no new trust-boundary or supply-chain exposure within this diff.
Optional, non-blocking: Since moving c/lua to github.com/llarhub/lua is a breaking relocation for any external consumer that imported the old path, consider noting the new import path in the release notes / changelog so downstream users can migrate smoothly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.