Repository navigation
mv c/zlib => github.com/llarhub/zlib - #62
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: Remove c/zlib (moved to github.com/llarhub/zlib)
This PR cleanly removes the entire c/zlib LLGo wrapper package (zlib.go, the README.md, and the three _demo programs) as part of relocating it to github.com/llarhub/zlib. I reviewed the deletion across code quality, performance, security, and documentation.
No issues found. The removal is complete and consistent:
- No dangling references — nothing in the repo imports
github.com/goplus/lib/c/zlib, and there are no remaining textual references tozlibanywhere (code, docs, or CI config). Thec/zlibdirectory is fully gone. - Build/CI intact —
go.modhas no zlib-specific dependency to prune, and the CI workflow never referenced the package.go build/test ./...simply drops it; build time is neutral-to-slightly-better. - Docs consistent — the top-level
README.mdis badges-only and keeps no package index, and no other README/doc links into the removed files, so nothing becomes stale. - Security clear — the deleted files contained only Apache-2.0 binding code and public install instructions (no secrets). The move target
github.com/llarhubis the legitimate official C/C++ library hub for the XGo/LLGo ecosystem (not a typo/squatter), so there's no dependency-confusion concern.
Optional (non-blocking)
Because Go has no redirect mechanism for a removed package path, downstream consumers still importing github.com/goplus/lib/c/zlib will hit a hard "package not found" error after this lands. Consider calling out the move in release notes / a CHANGELOG (or a brief migration note) so existing users know to switch to github.com/llarhub/zlib. This is a communication nicety only and does not require any change to this diff.
No description provided.