Repository navigation
mv c/sqlite => github.com/llarhub/sqlite - #61
Merged
Merged
Conversation
There was a problem hiding this comment.
Review: Remove c/sqlite package
This PR is a clean, pure deletion that removes the entire c/sqlite package (3 files, 355 deletions, 0 additions), relocating it to github.com/llarhub/sqlite per the commit message.
Verification performed (via automated code-quality, performance, security, and documentation-accuracy passes):
- No source file imports or references
github.com/goplus/lib/c/sqlite— the deletion breaks no builds. - The
c/sqlite/directory is fully removed; no stray files remain. - No docs index, top-level README,
CHANGELOG,go.mod,c/llcppg.pub, or CI config references the package. - No secrets, trust-boundary, or performance impact from the removal.
- Remaining
sqlitematches inpy/pandas/gen.goare unrelated generated pandas docstrings about Python'ssqlite3module.
No blocking issues found. The removal is complete and safe.
Optional, pre-existing (out of scope — not introduced by this PR):
c/libuv/README.md:42still shows the examplecd _demo/sqlitedemo, but libuv has no such demo (its demos areasync_fs/echo_server). This is a stale copy-paste artifact that predates this PR. Now that the repo's onlysqlitedemois being removed, you may want to fix that example to a real libuv demo in a separate change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.