chore: Add Gemfile.lock to google-cloud-spanner#238
Conversation
torreypayne
changed the title
torreypayne
force-pushed
the
add-gemfile-lock-spanner
branch
from
8f16873 to
21502a0
Compare
aandreassa
left a comment
aandreassa
left a comment
There was a problem hiding this comment.
Looks great! Can you pls check out this comment? #237 (review)
I think we can exclude the file from Rubygems publication just to be safe.
Add Gemfile.lock to the handwritten library to ensure consistent dependency versions in development and CI. Update CONTRIBUTING.md to remove the incorrect root-level bundle install instruction and add a note about managing Gemfile.lock. Fix NameError in doctest_helper.rb by explicitly requiring 'ostruct'. Update gemspec to reject Gemfile.lock from package files. Addresses b/509981628
torreypayne
force-pushed
the
add-gemfile-lock-spanner
branch
from
21502a0 to
fecddaf
Compare
|
|
||
| gem.files = `git ls-files -- lib/*`.split("\n") + | ||
| ["OVERVIEW.md", "AUTHENTICATION.md", "LOGGING.md", "CONTRIBUTING.md", "TROUBLESHOOTING.md", "CHANGELOG.md", "CODE_OF_CONDUCT.md", "LICENSE", ".yardopts"] | ||
| gem.files.reject! { |f| f.end_with? "Gemfile.lock" } |
There was a problem hiding this comment.
@aandreassa LMK how this looks (.end_with? should address any path-matching issues)
There was a problem hiding this comment.
FWIW I ran gem build locally and it wasn't being included anyways, but still a good call to include this:
!!! GEM FILES BEFORE REJECT: []
!!! ALL GEM FILES BEFORE REJECT COUNT: 66
!!! GEM FILES AFTER REJECT: []
!!! ALL GEM FILES AFTER REJECT COUNT: 66
There was a problem hiding this comment.
Thanks for checking it! Then we can probably go either way for this PR, up to you.
We should probably exclude going forward if it will make the migration / configs simpler.
There was a problem hiding this comment.
Ya let's keep the exclusion!
|
|
||
| gem.files = `git ls-files -- lib/*`.split("\n") + | ||
| ["OVERVIEW.md", "AUTHENTICATION.md", "LOGGING.md", "CONTRIBUTING.md", "TROUBLESHOOTING.md", "CHANGELOG.md", "CODE_OF_CONDUCT.md", "LICENSE", ".yardopts"] | ||
| gem.files.reject! { |f| f.end_with? "Gemfile.lock" } |
There was a problem hiding this comment.
Thanks for checking it! Then we can probably go either way for this PR, up to you.
We should probably exclude going forward if it will make the migration / configs simpler.
2 participants
Add Gemfile.lock to the handwritten library to ensure consistent dependency versions in development and CI. Update CONTRIBUTING.md to remove the incorrect root-level bundle install instruction and add a note about managing Gemfile.lock.