Skip to content

docs: warnings about with_tracing()#5240

Merged
coryan merged 2 commits intogoogleapis:mainfrom
coryan:docs-with-tracing-warning-and-features
Apr 13, 2026
Merged

docs: warnings about with_tracing()#5240
coryan merged 2 commits intogoogleapis:mainfrom
coryan:docs-with-tracing-warning-and-features

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Apr 2, 2026

Fixes #4752

We may want to wait until all the feature is enabled in all client libraries.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (5002c76) to head (0aa7d9c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5240   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         222      222           
  Lines       46609    46609           
=======================================
  Hits        45486    45486           
  Misses       1123     1123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review April 2, 2026 08:55
@coryan coryan requested a review from a team as a code owner April 2, 2026 08:55
Copy link
Copy Markdown
Contributor

@westarle westarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small tweaks to cover metrics.

Comment thread src/gax/src/client_builder.rs Outdated
Comment thread src/gax/src/client_builder.rs Outdated
Comment thread src/gax/src/client_builder.rs Outdated
Copy link
Copy Markdown
Contributor Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Comment thread src/gax/src/client_builder.rs Outdated
Comment thread src/gax/src/client_builder.rs Outdated
@westarle
Copy link
Copy Markdown
Contributor

westarle commented Apr 3, 2026

LGTM, agree that we should wait til we remove the flags.

@coryan coryan added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2026
@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Apr 13, 2026

Can I merge this now? Looks like all the flags are being removed.

@coryan coryan removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 13, 2026
@coryan coryan force-pushed the docs-with-tracing-warning-and-features branch from c928e6b to 0aa7d9c Compare April 13, 2026 15:51
@coryan coryan requested a review from a team as a code owner April 13, 2026 15:51
@westarle
Copy link
Copy Markdown
Contributor

Can I merge this now? Looks like all the flags are being removed.

Yes please!

@coryan coryan enabled auto-merge (squash) April 13, 2026 16:05
@coryan coryan merged commit e703822 into googleapis:main Apr 13, 2026
36 checks passed
@coryan coryan deleted the docs-with-tracing-warning-and-features branch April 13, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent warning about debug logs and traces

3 participants