Skip to content

feat(auth): universe domain support - WIP#5146

Closed
alvarowolfx wants to merge 22 commits intogoogleapis:mainfrom
alvarowolfx:feat-universe-domain
Closed

feat(auth): universe domain support - WIP#5146
alvarowolfx wants to merge 22 commits intogoogleapis:mainfrom
alvarowolfx:feat-universe-domain

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

Towards #3646

This PR will be broken down into smaller ones. It's just experimentation and to show the big picture.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 91.96787% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.56%. Comparing base (0de1339) to head (6e5412a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/auth/src/credentials/impersonated.rs 53.84% 6 Missing ⚠️
src/auth/src/credentials.rs 80.76% 5 Missing ⚠️
src/auth/src/mds/client.rs 95.74% 4 Missing ⚠️
src/auth/src/credentials/user_account.rs 0.00% 3 Missing ⚠️
src/gax-internal/src/host.rs 97.50% 1 Missing ⚠️
src/gax-internal/src/http.rs 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5146      +/-   ##
==========================================
- Coverage   97.59%   97.56%   -0.03%     
==========================================
  Files         222      222              
  Lines       46609    46826     +217     
==========================================
+ Hits        45486    45685     +199     
- Misses       1123     1141      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan
Copy link
Copy Markdown
Contributor

coryan commented Apr 13, 2026

Is it time to close this PR? It is several weeks old by now.

@alvarowolfx
Copy link
Copy Markdown
Contributor Author

Is it time to close this PR? It is several weeks old by now.

sure, I'll reopen later when time comes to make the API public for overriding universe domain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants