feat(auth): universe domain support - WIP#5146
Closed
alvarowolfx wants to merge 22 commits intogoogleapis:mainfrom
Closed
feat(auth): universe domain support - WIP#5146alvarowolfx wants to merge 22 commits intogoogleapis:mainfrom
alvarowolfx wants to merge 22 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5146 +/- ##
==========================================
- Coverage 97.59% 97.56% -0.03%
==========================================
Files 222 222
Lines 46609 46826 +217
==========================================
+ Hits 45486 45685 +199
- Misses 1123 1141 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Is it time to close this PR? It is several weeks old by now. |
Contributor
Author
sure, I'll reopen later when time comes to make the API public for overriding universe domain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3646
This PR will be broken down into smaller ones. It's just experimentation and to show the big picture.