chore: update client post-processing rules for gapic-generator 1.39.0 and regen - #18245
Closed
JoeWang1127 wants to merge 5 commits into
Closed
chore: update client post-processing rules for gapic-generator 1.39.0 and regen#18245JoeWang1127 wants to merge 5 commits into
JoeWang1127 wants to merge 5 commits into
Conversation
JoeWang1127
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum dependency constraint for google-api-core[grpc] to >= 2.28.0 across multiple package integration configurations. It also refactors the google-ads-admanager package by introducing a compatibility module (_compat.py) to handle older versions of google-api-core and utilizing a unified transcode_request helper. This refactoring removes significant boilerplate code from the REST transport classes. There are no review comments to address, and we have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
__init__.pyand__all__post-processing patterns for PEP 810 lazy imports