fix(googleapis-common-protos): remove deprecated license classifier - #18242
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml file for googleapis-common-protos by simplifying the license field to a string value "Apache-2.0" and removing the "License :: OSI Approved :: Apache Software License" classifier. There are no review comments, and I have no feedback to provide.
parthea
approved these changes
Aug 28, 2026
parthea
enabled auto-merge (squash)
August 28, 2026 16:33
ohmayr
approved these changes
Aug 28, 2026
daniel-sanche
pushed a commit
to daniel-sanche/google-cloud-python
that referenced
this pull request
Aug 28, 2026
…oogleapis#18242) This PR drops the deprecated classifier from the project metadata of googleapis-common-protos. It also fixes the license to be SPDX-compliant which was also warned during the built of the project (https://spdx.org/licenses/): ```log ******************************************************************************** Please use a simple string containing a SPDX expression for `project.license`. You can also use `project.license-files`. (Both options available on setuptools>=77.0.0). By 2027-Feb-18, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details. ******************************************************************************** ``` Closes googleapis#18235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the deprecated classifier from the project metadata of googleapis-common-protos.
It also fixes the license to be SPDX-compliant which was also warned during the built of the project (https://spdx.org/licenses/):
Closes #18235