chore(tests): break up sqlalchemy system tests - #18239
Draft
daniel-sanche wants to merge 7 commits into
Draft
Conversation
daniel-sanche
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures a dedicated Kokoro job for SQLAlchemy compliance tests and updates the system job to skip them. Feedback on the changes suggests adding the missing build_file definition to the new Kokoro configuration to prevent job failures, and using safer parameter expansion in the shell script to avoid unbound variable errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
marked this pull request as ready for review
August 28, 2026 18:24
daniel-sanche
requested review from
julianxu-goog
and removed request for
a team
August 28, 2026 18:24
daniel-sanche
marked this pull request as draft
August 28, 2026 18:25
daniel-sanche
commented
Aug 28, 2026
| |GA| |pypi| |versions| | ||
|
|
||
| `SQLALchemy Dialects`_ | ||
| `SQLAlchemy Dialects`_ |
Contributor
Author
There was a problem hiding this comment.
I asked Gemini to find typos to fix to trigger the tests, instead of adding a temporary change. It found a couple!
daniel-sanche
marked this pull request as ready for review
August 28, 2026 19:26
daniel-sanche
marked this pull request as draft
August 28, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sqlalchemy-spanner and sqlalchemy-bigquery have two sets of integration tests: standard system tests, and "compliance" checks. Each of these can take > 1 hour, which can put strain on our single kokoro system test when run sequentially
This PR drops the compliance checks from the
Kokoro Systemcheck, and breaks them out into their own test run