test(secretmanager): add integration and unit parametrization to include OTel integration testing - #18217
Draft
chalmerlowe wants to merge 2 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request parameterizes the unit test session in noxfile.py to optionally install OpenTelemetry dependencies, but changes the test path to run all tests (including integration tests) when enabled, while deleting the dedicated integration session. The review feedback correctly points out that running integration tests in the unit session will cause CI failures due to missing credentials and recommends keeping unit tests restricted to tests/unit and restoring the separate integration session.
chalmerlowe
force-pushed
the
feat/otel-tracing-transport-logic
branch
4 times, most recently
from
August 31, 2026 15:42
2669ca4 to
2bbbca4
Compare
chalmerlowe
force-pushed
the
feat/otel-tracing-integration-tests
branch
from
September 1, 2026 10:50
ca7f1a9 to
b4c99cd
Compare
chalmerlowe
force-pushed
the
feat/otel-tracing-transport-logic
branch
from
September 1, 2026 11:31
2bbbca4 to
a4c667a
Compare
chalmerlowe
force-pushed
the
feat/otel-tracing-integration-tests
branch
from
September 1, 2026 11:33
b4c99cd to
dd43fbc
Compare
chalmerlowe
force-pushed
the
feat/otel-tracing-transport-logic
branch
from
September 1, 2026 13:07
a4c667a to
41f5983
Compare
chalmerlowe
force-pushed
the
feat/otel-tracing-integration-tests
branch
from
September 1, 2026 13:08
dd43fbc to
40a2b2f
Compare
chalmerlowe
force-pushed
the
feat/otel-tracing-transport-logic
branch
from
September 1, 2026 17:18
41f5983 to
82fe99c
Compare
…local in-memory gRPC server
chalmerlowe
force-pushed
the
feat/otel-tracing-integration-tests
branch
from
September 1, 2026 17:23
40a2b2f to
e3c2031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is NOT intended to be merged. It is a proof-of-concept intended to inform the design and implementation of changes that need to be made in the GAPIC Generator templates.