feat(google/firestore/v1): onboard a new library#8859
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new package, @google-cloud/firestore-api, containing the auto-generated Node.js client for both the Cloud Firestore data and admin APIs. The review feedback highlights that several files (including package.json, README.md, and webpack.config.js) incorrectly describe the package as solely an admin client or contain incorrect links. The reviewer recommends updating the upstream generator templates for the auto-generated files and provides specific code suggestions to correct the package description and webpack library name.
quirogas
force-pushed
the
feat/onboard-firestore-api
branch
3 times, most recently
from
July 20, 2026 18:36
b59683a to
ba61375
Compare
quirogas
marked this pull request as ready for review
July 20, 2026 18:58
feywind
reviewed
Jul 20, 2026
feywind
left a comment
feywind
left a comment
Contributor
There was a problem hiding this comment.
Looks good besides the README.
quirogas
force-pushed
the
feat/onboard-firestore-api
branch
from
July 20, 2026 20:15
ba61375 to
6e6a41b
Compare
feywind
approved these changes
Jul 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.