Skip to content

feat(google/devtools/clouderrorreporting/v1beta1): onboard a new library#8858

Closed
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:feat/onboard-error-reporting-api
Closed

feat(google/devtools/clouderrorreporting/v1beta1): onboard a new library#8858
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:feat/onboard-error-reporting-api

Conversation

@quirogas

@quirogas quirogas commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new @google-cloud/error-reporting-api package, which is a Node.js client for the Google Cloud Error Reporting API. It includes the auto-generated client libraries, protocol buffers, samples, tests, and configuration files. The review feedback highlights a few issues: a version mismatch in librarian.yaml (set to 1.0.0 instead of 0.1.0), incorrect repository paths in the generated README.md links, and an overly specific library name (ErrorGroupService) in the Webpack configuration that should be generalized to ErrorReporting since the package contains multiple services.

Comment thread librarian.yaml Outdated
Comment thread librarian.yaml
Comment thread packages/google-cloud-error-reporting-api/webpack.config.js Outdated
@quirogas
quirogas force-pushed the feat/onboard-error-reporting-api branch 2 times, most recently from 6829745 to 73a22ca Compare July 20, 2026 18:29
@quirogas quirogas self-assigned this Jul 20, 2026
@quirogas
quirogas force-pushed the feat/onboard-error-reporting-api branch from 73a22ca to dd97fdf Compare July 20, 2026 18:36
@quirogas
quirogas marked this pull request as ready for review July 20, 2026 18:58
@quirogas
quirogas requested a review from a team as a code owner July 20, 2026 18:58
@feywind

feywind commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Do we need this one? Or was it an accident vs google.logging.v2?

@quirogas
quirogas force-pushed the feat/onboard-error-reporting-api branch from dd97fdf to b1e9543 Compare July 20, 2026 20:15
@quirogas

quirogas commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Do we need this one? Or was it an accident vs google.logging.v2?

Yes :(

@quirogas quirogas closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@quirogas quirogas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quirogas @feywind