Skip to content

feat(google/datastore/v1): onboard a new library#8856

Merged
feywind merged 1 commit into
googleapis:mainfrom
quirogas:feat/onboard-datastore-api
Jul 20, 2026
Merged

feat(google/datastore/v1): onboard a new library#8856
feywind merged 1 commit into
googleapis:mainfrom
quirogas:feat/onboard-datastore-api

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

No description provided.

@quirogas
quirogas requested a review from a team as a code owner July 10, 2026 21:05
@quirogas
quirogas marked this pull request as draft July 10, 2026 21:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the auto-generated @google-cloud/datastore-api package, onboarding client libraries, protobuf definitions, samples, and tests for both the main Datastore and Datastore Admin APIs. However, a critical issue was identified where sequential generation runs caused the admin API generation to overwrite several shared files. As a result, DatastoreClient is completely missing from the package exports, which breaks the test suite. Additionally, the package description, README links, and webpack configuration are incorrect because they only reference the admin client instead of the entire Datastore API. The generation orchestrator or configuration needs to be updated to ensure both clients are generated and exported together.

Comment thread packages/google-cloud-datastore-api/src/v1/index.ts
Comment thread packages/google-cloud-datastore-api/src/index.ts Outdated
Comment thread packages/google-cloud-datastore-api/test/gapic_datastore_v1.ts
Comment thread packages/google-cloud-datastore-api/package.json Outdated
Comment thread packages/google-cloud-datastore-api/README.md Outdated
Comment thread packages/google-cloud-datastore-api/webpack.config.js Outdated
@quirogas quirogas changed the title feat: onboard datastore api feat(google/datastore/v1): onboard a new library Jul 10, 2026
@quirogas
quirogas force-pushed the feat/onboard-datastore-api branch from c270c15 to d65d7a6 Compare July 10, 2026 21:13
@quirogas
quirogas force-pushed the feat/onboard-datastore-api branch 2 times, most recently from 48ba81c to ab154cf Compare July 20, 2026 18:26
@quirogas quirogas self-assigned this Jul 20, 2026
@quirogas
quirogas force-pushed the feat/onboard-datastore-api branch from ab154cf to 48c33be Compare July 20, 2026 18:36
@quirogas
quirogas marked this pull request as ready for review July 20, 2026 18:58
Comment thread packages/google-cloud-datastore-api/README.md
@quirogas
quirogas force-pushed the feat/onboard-datastore-api branch from 48c33be to d65b345 Compare July 20, 2026 20:14
@quirogas
quirogas requested a review from feywind July 20, 2026 20:25
@feywind
feywind merged commit 0e2dc22 into googleapis:main Jul 20, 2026
34 checks passed
@release-please release-please Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants