Skip to content

feat(gax): add ResumableUploadCallable creation to Callables and HttpJsonCallableFactory - #14242

Draft
whowes wants to merge 1 commit into
whowes/resumable-upload-happy-pathfrom
whowes/resumable-upload-factory
Draft

feat(gax): add ResumableUploadCallable creation to Callables and HttpJsonCallableFactory#14242
whowes wants to merge 1 commit into
whowes/resumable-upload-happy-pathfrom
whowes/resumable-upload-factory

Conversation

@whowes

@whowes whowes commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This change wires up the minimal Callable implementation from #14241 into the relevant existing factory classes.

gemini-code-assist[bot]

This comment was marked as outdated.

@whowes
whowes force-pushed the whowes/resumable-upload-factory branch 2 times, most recently from aef944f to 8cca7df Compare September 2, 2026 17:30
@whowes
whowes force-pushed the whowes/resumable-upload-factory branch from 8cca7df to 13ed5aa Compare September 2, 2026 19:01
@whowes
whowes force-pushed the whowes/resumable-upload-factory branch from 13ed5aa to cb17291 Compare September 2, 2026 19:11
@whowes
whowes force-pushed the whowes/resumable-upload-factory branch 2 times, most recently from 3c30fa0 to f88f691 Compare September 2, 2026 22:07
@whowes
whowes force-pushed the whowes/resumable-upload-factory branch from f88f691 to c36a2ad Compare September 2, 2026 22:32
@whowes

whowes commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for resumable uploads in the HTTP/JSON transport layer by adding the createResumableUploadCallable factory method to HttpJsonCallableFactory and the resumableUpload utility method to Callables. Corresponding unit tests have also been added to verify their behavior. There are no review comments, so I have no feedback to provide.

@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant