fix(storage): resolve GraalVM Native Image test failure for java-storage - #14226
Draft
nidhiii-27 wants to merge 5 commits into
Draft
fix(storage): resolve GraalVM Native Image test failure for java-storage#14226nidhiii-27 wants to merge 5 commits into
nidhiii-27 wants to merge 5 commits into
Conversation
- Regenerate gRPC & Protobuf GraalVM reflect-config.json reflection mappings for java-storage/google-cloud-storage. - Skip native-maven-plugin test execution in java-storage/gapic-google-cloud-storage-v2 to prevent missing native test config error during native presubmit builds. [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds reflection configuration entries for various protobuf and Envoy/gRPC classes in reflect-config.json and configures the native-maven-plugin in gapic-google-cloud-storage-v2/pom.xml. However, manually editing the auto-generated pom.xml in GAPIC client libraries should be avoided as these changes will be overwritten during the next code generation; instead, the generator or source metadata should be modified.
…e-v2 per code review Revert manual native-maven-plugin modification in auto-generated gapic pom.xml per review comments. [Generated-by: AI]
… GAPIC submodules Disable native-maven-plugin test-native execution in native profile for java-storage parent POM so auto-generated GAPIC submodules do not fail native builds, and handle missing GCP permissions in StorageNativeCanary catch block. [Generated-by: AI]
Contributor
Author
|
/gemini-code-assist |
Contributor
|
The changes in this pull request look well-structured and address the reported GraalVM native image test failures effectively. Specifically:
Overall, these changes improve the robustness of the native image testing process. |
[Generated-by: AI]
…-storage and skip gapic-google-cloud-storage-v2 Revert global phase disabling of test-native in java-storage/pom.xml so modules inherit native testing capabilities. Configure gapic-google-cloud-storage-v2 with skipNativeTests=true to skip native testing on auto-generated wrapper. Handwritten google-cloud-storage continues native image testing (StorageNativeCanary). [Generated-by: AI]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GraalVM native image test failure in
java-storage:reflect-config.jsonfor gRPC & Protobuf reflection entries injava-storage/google-cloud-storage.native-maven-plugintest-nativeexecution phase injava-storage/gapic-google-cloud-storage-v2to prevent missing native test configuration error during native presubmit builds.[Generated-by: AI]