feat(gax): add ResumableUploadResultRetryAlgorithm

[whowes]

Work in progress - not ready for review

[gemini-code-assist]

Code Review

This pull request introduces the ResumableUploadResultRetryAlgorithm class and its corresponding unit tests to handle retries for resumable uploads based on the Unified Resumable Upload Protocol specification. The feedback identifies an issue where non-ApiException throwables (such as IOException) would still be retried even when the RetryingContext explicitly overrides and restricts the retryable codes. To ensure consistency, the algorithm should return false for non-ApiExceptions when custom retryable codes are provided in the context, and a corresponding test assertion should be added to verify this behavior.

[gemini-code-assist]

When context.getRetryableCodes() is not null, it indicates that the caller has explicitly overridden the retryable codes for this call (for example, by setting an empty set to disable retries).

In the current implementation, if previousThrowable is not an instance of ApiException (such as an IOException), the code falls through to shouldRetry(previousThrowable, previousResponse), which returns true for IOException. This means IOExceptions would still be retried even if retries were explicitly disabled or customized via the context.

To ensure consistency with other retry algorithms in GAX (like ApiExceptionRetryAlgorithm), we should return false for any non-ApiException when context.getRetryableCodes() is configured.

Suggested change

	if (context.getRetryableCodes() != null) {
	if (previousThrowable instanceof ApiException) {
	return context
	.getRetryableCodes()
	.contains(((ApiException) previousThrowable).getStatusCode().getCode());
	}
	}
	if (context.getRetryableCodes() != null) {
	if (previousThrowable instanceof ApiException) {
	return context
	.getRetryableCodes()
	.contains(((ApiException) previousThrowable).getStatusCode().getCode());
	}
	return false;
	}

[gemini-code-assist]

Add an assertion to verify that IOException is not retried when the context overrides the retryable codes (e.g., with an empty set).

Suggested change

	// Default algorithm retries UNAVAILABLE, but context with empty codes forbids it
	assertThat(algorithm.shouldRetry(contextWithEmptyCodes, unavailable, null)).isFalse();
	// Default algorithm retries UNAVAILABLE, but context with empty codes forbids it
	assertThat(algorithm.shouldRetry(contextWithEmptyCodes, unavailable, null)).isFalse();
	// IOException should also not be retried when retryable codes are overridden by the context
	IOException ioException = new IOException("connection reset");
	assertThat(algorithm.shouldRetry(contextWithEmptyCodes, ioException, null)).isFalse();

[sonarqubecloud]

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
76.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud