chore(spanner): clean up pre-existing backup schedules in samples and… - #14221
Open
sakthivelmanii wants to merge 1 commit into
Open
chore(spanner): clean up pre-existing backup schedules in samples and…#14221sakthivelmanii wants to merge 1 commit into
sakthivelmanii wants to merge 1 commit into
Conversation
… increase replica harness wait timeout
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the timeout from 10 to 30 seconds in LocationAwareSharedBackendReplicaHarnessTest to prevent test flakiness. It also introduces a pre-test cleanup mechanism for backup schedules across several integration tests by adding a @before hook that invokes a new helper method cleanUpPreExistingBackupSchedules in SampleTestBaseV2. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… increase replica harness wait timeout