feat(spanner): add sample codes and sample ITs for Cloud Spanner Queues. - #14203
Open
finnzzf wants to merge 3 commits into
Open
feat(spanner): add sample codes and sample ITs for Cloud Spanner Queues.#14203finnzzf wants to merge 3 commits into
finnzzf wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new QueueSample class and its corresponding integration test QueueSampleIT to demonstrate Spanner queue operations, including database creation, sending, receiving, acknowledging, and deleting messages using both Mutation and SQL APIs. The review feedback suggests improving exception handling in the sample code by propagating exceptions in createQueueDatabase instead of catching and swallowing them, which simplifies the code and ensures failures are properly propagated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding sample codes and tests for queues.