feat(gax): implement uploadChunkCallable for resumable uploads - #14140
Draft
whowes wants to merge 1 commit into
Draft
feat(gax): implement uploadChunkCallable for resumable uploads#14140whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 19, 2026 23:36
faf99d0 to
010c0aa
Compare
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 20, 2026 00:06
010c0aa to
baee7f0
Compare
Contributor
Author
|
/gemini review |
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 20, 2026 00:10
baee7f0 to
8a6d2fc
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for transmitting individual chunks in a resumable upload session by adding ChunkUploadRequest and ChunkUploadResponse classes, implementing uploadChunkCallable() in HttpJsonResumableUploadClient, and adding corresponding unit tests. Feedback was provided to change the HTTP method in UPLOAD_CHUNK_DESCRIPTOR from POST to PUT to comply with the Google Scotty resumable upload protocol.
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 20, 2026 01:38
8a6d2fc to
1c123a9
Compare
|
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 20, 2026 20:56
1c123a9 to
d1a4963
Compare
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 21, 2026 00:37
d1a4963 to
0dcb287
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
3 times, most recently
from
August 25, 2026 01:03
839a11f to
e6fd648
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 25, 2026 16:34
e6fd648 to
c851386
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 25, 2026 21:44
c851386 to
3e9ab99
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 25, 2026 22:00
3e9ab99 to
4937751
Compare
Contributor
Author
|
/gemini review |
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 27, 2026 01:37
ec5629f to
b0ea176
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 27, 2026 01:49
b0ea176 to
d3abc11
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 27, 2026 01:50
d3abc11 to
f4acebc
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 27, 2026 15:27
f4acebc to
5268b3c
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 27, 2026 20:15
5268b3c to
7b0fff7
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
2 times, most recently
from
August 27, 2026 23:52
8e33b86 to
a6c4e6d
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 28, 2026 01:34
a6c4e6d to
f91782f
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
2 times, most recently
from
August 28, 2026 16:49
bbcdbb0 to
780a677
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 28, 2026 17:02
780a677 to
65db78a
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 28, 2026 17:23
65db78a to
356b549
Compare
whowes
force-pushed
the
whowes/resumable-upload-chunk
branch
from
August 28, 2026 19:11
356b549 to
2beec8b
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles sending binary chunks and finalize commands over HTTP/JSON, extracting offset and status from response headers/codes.