-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(storage): add support for DirectPath over Interconnect #14006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nidhiii-27
wants to merge
5
commits into
main
Choose a base branch
from
add-dp-over-gci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
23147be
feat(storage): add support for DirectPath over Interconnect
nidhiii-27 213ada7
chore: ignore integration test due to environment constraints
nidhiii-27 c1b4f5f
Merge branch 'main' into add-dp-over-gci
nidhiii-27 e0177bd
Merge branch 'main' into add-dp-over-gci
nidhiii-27 aee5030
fix(storage): resolve review comments for DirectPath over Interconnect
nidhiii-27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
.../google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITGrpcDirectPathTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.storage.it; | ||
|
|
||
| import static org.junit.Assume.assumeTrue; | ||
|
|
||
| import com.google.cloud.storage.Storage; | ||
| import com.google.cloud.storage.StorageOptions; | ||
| import com.google.cloud.storage.TransportCompatibility.Transport; | ||
| import com.google.cloud.storage.it.runner.StorageITRunner; | ||
| import com.google.cloud.storage.it.runner.annotations.Backend; | ||
| import com.google.cloud.storage.it.runner.annotations.Inject; | ||
| import com.google.cloud.storage.it.runner.annotations.SingleBackend; | ||
| import com.google.cloud.storage.it.runner.annotations.StorageFixture; | ||
| import org.junit.Ignore; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| @RunWith(StorageITRunner.class) | ||
| @SingleBackend(Backend.PROD) | ||
| public final class ITGrpcDirectPathTest { | ||
|
|
||
| @Inject | ||
| @StorageFixture(Transport.GRPC) | ||
| public Storage storage; | ||
|
|
||
| @Ignore( | ||
| "Bypassed because DirectPath over Interconnect (GCI) requires a specialized hybrid network environment (Interconnect and Traffic Director configured for storage-direct) and cannot be validated in standard CI or local workstations.") | ||
| @Test | ||
| public void clientShouldWork_directPathXdsOverInterconnect() throws Exception { | ||
| assumeTrue( | ||
| "Environment cannot resolve storage-direct.googleapis.com", canResolveDirectPathAddress()); | ||
| StorageOptions options = | ||
| StorageOptions.grpc() | ||
| .setCredentials(storage.getOptions().getCredentials()) | ||
| .setAttemptDirectPathXdsOverInterconnect(true) | ||
| .setEnableGrpcClientMetrics(false) | ||
| .build(); | ||
| try (Storage client = options.getService()) { | ||
| client.list(Storage.BucketListOption.pageSize(1)); | ||
| } | ||
| } | ||
|
|
||
| private static boolean canResolveDirectPathAddress() { | ||
| try { | ||
| java.net.InetAddress.getAllByName("storage-direct.googleapis.com"); | ||
| return true; | ||
| } catch (java.net.UnknownHostException e) { | ||
| return false; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are unused and the string literals are hardcoded in rewriteHost() and overrideAuthority().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Replaced hardcoded string literals in rewriteHost() and overrideAuthority() with DEFAULT_HOST_DIRECT_PATH and DEFAULT_HOST_NO_SCHEME constants.
Co-authored by AI Agent