Skip to content

chore: add org.bouncycastle:bcprov-jdk18on to java-shared-dependencies #13531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sagnghos wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −0
Draft

chore: add org.bouncycastle:bcprov-jdk18on to java-shared-dependencies #13531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b3a441
chore: add org.bouncycastle:bcprov-jdk18on to java-shared-dependencies
sagnghos Jun 20, 2026
8c14085
Update sdk-platform-java/java-shared-dependencies/third-party-depende…
sagnghos Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdk-platform-java/java-shared-dependencies/third-party-dependencies/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,19 @@
<flogger.version>0.8</flogger.version>
<arrow.version>17.0.0</arrow.version>
<dev.cel.version>0.6.0</dev.cel.version>
<bouncycastle.version>1.80</bouncycastle.version>
<com.google.crypto.tink.version>1.16.0</com.google.crypto.tink.version>
<io.opentelemetry.contrib.opentelemetry-gcp-resources.version>1.45.0-alpha</io.opentelemetry.contrib.opentelemetry-gcp-resources.version>
<json.version>20250517</json.version>
</properties>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
<version>${bouncycastle.version}</version>
</dependency>
Comment on lines +53 to +57

@gemini-code-assist gemini-code-assist Bot Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dependencies in <dependencyManagement> should be sorted alphabetically by groupId and artifactId to maintain consistency and avoid merge conflicts. Please move the org.bouncycastle dependency block to its correct alphabetical position (e.g., after org.apache.arrow).

<dependency>
<groupId>org.apache.arrow</groupId>
<artifactId>arrow-memory-core</artifactId>
Expand Down
4 changes: 4 additions & 0 deletions sdk-platform-java/java-shared-dependencies/upper-bound-check/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,5 +247,9 @@
<groupId>org.jspecify</groupId>
<artifactId>jspecify</artifactId>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
</dependency>
Comment on lines +250 to +253

@gemini-code-assist gemini-code-assist Bot Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dependencies in this POM should be sorted alphabetically by groupId and artifactId. Please move the org.bouncycastle dependency block before org.jspecify.

</dependencies>
</project>
Loading