Skip to content

Conversation

@daniel-sanche
Copy link
Collaborator

@daniel-sanche daniel-sanche commented Jan 16, 2026

Add new required dependency to test constraints, to ensure minimum versions are tested

Also, moved constraints file to 3.8, since 3.7 is no longer supported

@daniel-sanche daniel-sanche requested review from a team as code owners January 16, 2026 18:26
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Python 3.7 test constraints by incorporating the cryptography library. The primary goal is to enforce a specific minimum version for this dependency during testing, thereby enhancing the reliability and consistency of the test suite across various environments.

Highlights

  • Dependency Management: Added cryptography==38.0.3 to the testing/constraints-3.7.txt file.
  • Testing Consistency: This addition ensures that minimum versions of required dependencies, specifically cryptography, are consistently tested within the Python 3.7 environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds cryptography to the test constraints file. While adding the dependency is correct to ensure minimum versions are tested, there's a potential issue with the file being modified. The file testing/constraints-3.7.txt targets Python 3.7, but the project's setup.py specifies that the minimum supported Python version is 3.8. Please see the specific comment for more details.

@daniel-sanche daniel-sanche merged commit 526d6c6 into main Jan 16, 2026
24 checks passed
@daniel-sanche daniel-sanche deleted the add_constraints branch January 16, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants