gma_mediation_meta: add SwiftPM (SPM) support — extends #1395 to the Meta mediation package#1435
Open
qeepcologne wants to merge 1 commit into
Open
gma_mediation_meta: add SwiftPM (SPM) support — extends #1395 to the Meta mediation package#1435qeepcologne wants to merge 1 commit into
qeepcologne wants to merge 1 commit into
Conversation
Adds a `Package.swift` so the plugin can be consumed by Flutter's Swift Package Manager iOS integration (no CocoaPods). The SPM target depends on `MetaAdapterTarget` from Google's `googleads-mobile-ios-mediation-meta` package — the SPM equivalent of the `GoogleMobileAdsMediationFacebook` pod the podspec declares. Sources moved from `ios/Classes/` to `ios/gma_mediation_meta/Sources/gma_mediation_meta/` (the layout SPM expects) and the podspec `source_files` repointed accordingly, so both CocoaPods and SPM consumers keep working.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Closing — SwiftPM rollout for this repo is being handled upstream (core landed in #1395). Keeping these mediation-package changes in our fork for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1395 added Swift Package Manager support to the core
google_mobile_adsplugin, but the mediation packages weren't included. This PR extends the same treatment togma_mediation_meta, so apps using Flutter's SwiftPM iOS integration (no CocoaPods) can link the Meta Audience Network mediation adapter.packages/mediation/gma_mediation_meta/ios/gma_mediation_meta/Package.swift. The SPM target depends onMetaAdapterTargetfrom Google'sgoogleads-mobile-ios-mediation-metapackage — the SPM equivalent of theGoogleMobileAdsMediationFacebookpod the podspec declares.google_mobile_adssupport for Swift Package Manager #1395 established forgoogle_mobile_ads: sources moved fromios/Classes/toios/gma_mediation_meta/Sources/gma_mediation_meta/, podspecsource_filesrepointed — both CocoaPods and SPM consumers keep working.Context
Distinct from #1395 (that one is the core plugin; this is the Meta mediation adapter package). The same approach would apply to the other
gma_mediation_*packages.Test plan
pod lib lint).MetaAdapterTargetand links the Meta adapter.