Skip to content

Add generic Ptr::try_with#2946

Merged
joshlf merged 1 commit intomainfrom
G7f73f342a0126d5f9b9dc44925f6ae7451034bef
Jan 29, 2026
Merged

Add generic Ptr::try_with#2946
joshlf merged 1 commit intomainfrom
G7f73f342a0126d5f9b9dc44925f6ae7451034bef

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Jan 28, 2026

This helper abstracts the logic of attempting to transform a Ptr, and
restoring it to its original type on failure.


Latest Update: v24 — Compare vs v23

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base

Stacked PRs enabled by GHerrit.

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.21%. Comparing base (381021b) to head (f6656e5).

Files with missing lines Patch % Lines
src/error.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   92.22%   92.21%   -0.02%     
==========================================
  Files          19       19              
  Lines        5830     5860      +30     
==========================================
+ Hits         5377     5404      +27     
- Misses        453      456       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the G7f73f342a0126d5f9b9dc44925f6ae7451034bef branch 3 times, most recently from 9312e5b to 4f7ace4 Compare January 28, 2026 17:19
@joshlf joshlf force-pushed the G7f73f342a0126d5f9b9dc44925f6ae7451034bef branch 8 times, most recently from 9b6af27 to c5c6edd Compare January 29, 2026 16:05
This helper abstracts the logic of attempting to transform a `Ptr`, and
restoring it to its original type on failure.

gherrit-pr-id: G7f73f342a0126d5f9b9dc44925f6ae7451034bef
@joshlf joshlf changed the title [WIP] Generic Ptr::try_with Add generic Ptr::try_with Jan 29, 2026
@joshlf joshlf force-pushed the G7f73f342a0126d5f9b9dc44925f6ae7451034bef branch from c5c6edd to f6656e5 Compare January 29, 2026 16:08
@joshlf joshlf enabled auto-merge January 29, 2026 16:09
@joshlf joshlf added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit d161a87 Jan 29, 2026
104 checks passed
@joshlf joshlf deleted the G7f73f342a0126d5f9b9dc44925f6ae7451034bef branch January 29, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants