Repository navigation
Fix corrupt local cache restores after Wireit is killed mid-write - #1516
Merged
Merged
Conversation
LocalCache.set copied output straight into the entry's final folder. If Wireit was killed or crashed part way through, the partial entry stayed in the cache, and later runs with the same inputs restored it instead of running the script, with files missing or truncated and no error. Now set copies into a temp folder under the script's ".wireit" folder and renames it into place. The temp folder is per script, so the script's lock tells a leftover from another process's write in progress. The next write moves leftovers to the trash.
augustjk
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalCache.set copied output straight into the entry's final folder. If Wireit was killed or crashed part way through, the partial entry stayed in the cache, and later runs with the same inputs restored it instead of running the script, with files missing or truncated and no error.
Now set copies into a temp folder under the script's ".wireit" folder and renames it into place. The temp folder is per script, so the script's lock tells a leftover from another process's write in progress. The next write moves leftovers to the trash.