Fix eos issues in sglang / vllm samplers during on-policy rollout#1148
Merged
copybara-service[bot] merged 2 commits intogoogle:mainfrom Feb 25, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
tianshub
approved these changes
Feb 25, 2026
Collaborator
tianshub
left a comment
There was a problem hiding this comment.
ah wow! thanks for the fix Bethany, this is huge improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation that leverages sglang/vllm samplers during rollout has some issues with the eos (e.g., <|im_end|> in Qwen models) which can make it problematic. This PR addresses this by removing the unnecessary (sometimes wrong) eos tokens in the input, to make RL more stable and effective.
On one benchmark that we experimented, we found this change has lead to significance in terms of the learning efficiency and quality.
Checklist