Move tsl/platform/* interface headers to xla/tsl/platform/*.#3551
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Move tsl/platform/* interface headers to xla/tsl/platform/*.#3551copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This is to fix a layering issue without introducing circular dependencies when using bzlmod. The implementations in xla/tsl/platform/default need direct access to the interface headers from the same repository (i.e. not from TSL `exports_files`) in order to propagate the correct `CcInfo` for determining proper include paths. Adding a direct dep back into `tsl/platform` would introduce a circular dependency. PiperOrigin-RevId: 910851800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tsl/platform/* interface headers to xla/tsl/platform/*.
This is to fix a layering issue without introducing circular dependencies
when using bzlmod. The implementations in xla/tsl/platform/default
need direct access to the interface headers from the same repository
(i.e. not from TSL
exports_files) in order to propagate the correctCcInfofor determining proper include paths. Adding a direct depback into
tsl/platformwould introduce a circular dependency.