Repository navigation
feat(cad): add SweepGeometry, HelixGeometry, HelixCurve3, and ExtrudeGeometry.extrudePath - #97
Merged
Merged
Conversation
…Geometry.extrudePath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Basic 3D Curve Sweeps & Helices to
three-live-cad:THREE.SweepGeometry(shape, path, options): Sweeps any 2DTHREE.Shape(including.holes) along any 3D curve (Curve3,CatmullRomCurve3, or 3D waypoint array) using rotation-minimizing Bishop frames (parallel transport) with closed-loop holonomy untwisting, progressivetwist, linear/3-point/callablescale(taper), watertight ear-clipped start/end caps, and non-degenerate tip triangle emission when tapering to zero scale.THREE.ExtrudeGeometry(..., { extrudePath }): Automatically delegates toSweepGeometrywhenextrudePath(orpath) is provided inExtrudeGeometryOptions.THREE.HelixCurve3&THREE.HelixGeometry: Parametric 3D helical spine and swept coil/spring/thread geometry supporting cylindrical or conical radii (radius,topRadius),pitch/height,turns,'right' | 'left'handedness, circulartubeRadius/wireRadiusor custom 2DShapeprofiles,twist,scale, andorigin: 'center' | 'bottom'.Testing
countBoundaryEdges === 0), normal-vs-winding (countNormalWindingMismatches === 0), closed-loop seam, hole-sweeping, zero-tip taper, and hostile-input fuzz tests inthree-live/tests/three_author_test.ts.