Generate complete static case fold orbits#206
Draft
ittaigolde wants to merge 2 commits into
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168.
This builds on #170's Unicode 10 table update and makes the fix independent of the runtime JDK's Unicode version.
I reproduced the hang on JDK 21 and scanned all Unicode codepoints with a bounded
simpleFold()orbit walker. Onmaster,U+1C80..U+1C88produce non-closing orbits. For example:#170 fixes the currently observed failures, but
simpleFold()still mixes generated ICU tables with the active JDK'sCharacter.toLowerCase()/toUpperCase()data. A later JDK could therefore introduce another incomplete orbit.Following @herbyderby's suggestion in #168, this change:
int[]pages, supporting supplementary codepoints;simpleFold();Preliminary JDK 21 microbenchmark, 20 million mixed lookups:
Estimated orbit-table memory:
These are informal measurements rather than JMH results.
Verification:
UnicodeTest,PatternTest, andCharClassTest;ExecTestandGWTTestthrough a standalone Gradle 9 runner.The excluded classes could not be validated faithfully in that runner on Windows:
ExecTestfixture parsing is affected by checkout line endings, andGWTTestexpects the legacy root build's resource layout. The repository's Gradle 5.2 wrapper does not start on JDK 21.