Skip to content

Fix handling of split when the input is fully matched and the limit is 0 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cushon wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix handling of split when the input is fully matched and the limit is 0 #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11aceb6
Fix handling of `split` when the input is fully matched and the limit…
cushon May 13, 2026
e120513
Add another test for splitting empty strings
cushon May 15, 2026
ed16a15
Merge branch 'master' into i197
sjamesr May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/com/google/re2j/Pattern.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private String[] split(Matcher m, int limit) {
result.add(m.substring(last, m.inputLength()));
}

if (limit != 0 || result.isEmpty()) {
if (limit != 0 || (result.isEmpty() && !(last == m.inputLength() && last > 0))) {
result.add(m.substring(last, m.inputLength()));
}

Expand Down
7 changes: 7 additions & 0 deletions javatests/com/google/re2j/PatternTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ public void testSplit() {
ApiTestUtils.testSplit("x*", "foo", 1, new String[] {"foo"});
ApiTestUtils.testSplit("x*", "f", 2, new String[] {"f", ""});
ApiTestUtils.testSplit(":", ":a::b", new String[] {"", "a", "", "b"});

// From https://github.com/google/re2j/issues/197.
// Test split when input is fully matched and limit is 0.
ApiTestUtils.testSplit("\\s+", " ", new String[] {});
ApiTestUtils.testSplit("\\s+", " foo", new String[] {"", "foo"});
ApiTestUtils.testSplit("\\s+", "foo ", new String[] {"foo"});
ApiTestUtils.testSplit("\\s+", "", new String[] {""});
}

@Test
Expand Down
Loading