refactor: return lazy Provider from DependencyUtil.resolveArtifacts#381
Open
timothyfroehlich wants to merge 1 commit intomainfrom
Open
refactor: return lazy Provider from DependencyUtil.resolveArtifacts#381timothyfroehlich wants to merge 1 commit intomainfrom
timothyfroehlich wants to merge 1 commit intomainfrom
Conversation
timothyfroehlich
force-pushed
the
refactor-lazy-provider
branch
2 times, most recently
from
e7f310d to
dff5638
Compare
Refactors artifact resolution to return a lazy Provider<Map<String, ArtifactFiles>> instead of an eager Map. - Introduced private performResolution helper to reduce indentation while maintaining laziness. - Scoped baseDir calculation within task registration for better readability. - Updated DependencyResolutionTest to handle the new Provider return type.
timothyfroehlich
force-pushed
the
refactor-lazy-provider
branch
from
dff5638 to
d84b4a3
Compare
liutikas
reviewed
Mar 11, 2026
| */ | ||
| static Map<String, ArtifactFiles> resolveArtifacts(Project project, Configuration runtimeConfiguration) { | ||
| static Provider<Map<String, ArtifactFiles>> resolveArtifacts(Project project, Configuration runtimeConfiguration) { | ||
| return project.provider { performResolution(project, runtimeConfiguration) } |
Collaborator
There was a problem hiding this comment.
We should not need to do this. The idea is that we should take runtimeConfiguration and use that to create a lazy FileCollection without wrapping it in project.provider.
Right now we are doing eager work and instead it should be lazy. Happy to discuss over GVC if that's helpful.
Member
Author
There was a problem hiding this comment.
It'll be good for me to figure this out on my own. I think my Gradle skills have atrophied a bit and I need to catch up with Gradle 9+ and AGP 9+ anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors artifact resolution to return a lazy
Provider<Map<String, ArtifactFiles>>instead of an eagerMap.This addresses technical debt identified in PR #365 by moving away from
project.providerwrapping and ensuring task inputs are correctly wired through the Lazy Configuration API.