fix: remove redundant LicensesCleanUpTask to fix implicit dependencies on Gradle 9.x#377
Closed
timothyfroehlich wants to merge 2 commits intomake-tasks-cacheablefrom
Closed
fix: remove redundant LicensesCleanUpTask to fix implicit dependencies on Gradle 9.x#377timothyfroehlich wants to merge 2 commits intomake-tasks-cacheablefrom
timothyfroehlich wants to merge 2 commits intomake-tasks-cacheablefrom
Conversation
timothyfroehlich
changed the base branch from
test-infra
to
make-tasks-cacheable
timothyfroehlich
force-pushed
the
fix-clean-task
branch
from
505862f to
72b1c91
Compare
This was referenced Mar 9, 2026
timothyfroehlich
force-pushed
the
make-tasks-cacheable
branch
from
fc60701 to
5b8301d
Compare
timothyfroehlich
force-pushed
the
fix-clean-task
branch
from
72b1c91 to
361c8cf
Compare
timothyfroehlich
force-pushed
the
make-tasks-cacheable
branch
from
5b8301d to
36a28dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #378
Chain of upstream PRs & tree of downstream PRs as of 2026-03-10
PR ci: run workflow on all pull requests #379:
main←ci-infra-updatePR feat: make plugin tasks cacheable and relocatable #378:
ci-infra-update←make-tasks-cacheablePR fix: remove redundant LicensesCleanUpTask to fix implicit dependencies on Gradle 9.x #377 (THIS ONE):
make-tasks-cacheable←fix-clean-taskPR test: modernize E2E matrix and enable configuration cache strict mode #376:
fix-clean-task←test-infraPR build: upgrade gradle wrapper to 9.4.0 in oss-licenses-plugin #375:
test-infra←gradle-upgradegradle-upgrade←froeht/integration-testsGradle 9.x promotes "Implicit Dependencies" to a hard failure. This occurred when running combined commands like
./gradlew clean test(or any command combining cleanup and build tasks), because the customLicensesCleanUpTaskand the generation tasks both touched the same directory without a declared relationship.Since the generated files reside within the
build/directory, the standard Gradlecleantask already handles their deletion. This PR removes the redundant cleanup logic entirely, simplifying the plugin and resolving the validation error.Closes #356, #300, #299.