Update to the latest internal version - #201
Merged
Merged
Conversation
PiperOrigin-RevId: 932659383
PiperOrigin-RevId: 934459293
…w buffers. ARM SPE traces are parsed using `ArmSpeDecoder`. Currently, it takes a single contiguous `std::string_view` as input, which assumes the entire trace buffer is contiguous in memory. This change modifies `ArmSpeDecoder` to take a non-contiguous buffer (pointer to multiple `std::string_view` segments and size) as input by using C++17 array-reference template deduction constructors. A helper class `SegmentedBuffer` is implemented to abstract multiple non-contiguous `string_view` buffers as a single contiguous stream. It provides indexing (`operator[]`), safe multicycle chunk copies (`ReadBytes`), and pointer resolution (`GetPointer`) for alignment calculation. With these changes, `ArmSpeDecoder` handles non-contiguous inputs seamlessly across boundary limits of individual segments. This is backwards compatible with single `string_view` traces, which are implicitly wrapped. The decoder uses view-type containers that don't own the input memory and the decoder doesn't make a copy of the data to avoid heap allocations and make it compatible with interrupt handlers. PiperOrigin-RevId: 956124896
…ils. PiperOrigin-RevId: 960560835
gmarin13
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.