Repository navigation
SystemSan: shell-quote repository moved from substack/node-shell-quote to ljharb/shell-quote - #16554
Open
tausif-ahmed-guardian wants to merge 1 commit into
Conversation
…e to ljharb/shell-quote
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
SystemSanshell-quote PoC no longer builds, because it cloneshttps://github.com/substack/node-shell-quote.git, which does not exist any more (git ls-remotereports "Repository not found"). The npm registry lists the project's repository ashttps://github.com/ljharb/shell-quote.Change
infra/experimental/SystemSan/PoEs/node-shell-quote-v1.7.3/Dockerfile: cloneljharb/shell-quoteat tagv1.7.3into the samenode-shell-quotedirectory, sobuild.sh(npm install ./node-shell-quote/) is unchanged. The tag is pinned because the old clone took the latest commit, which was v1.7.3 at the time. The new repository's default branch is a later release, so an unpinned clone would no longer test v1.7.3.infra/experimental/SystemSan/README.mdlines 51 and 55: point the two links atljharb/shell-quote.The Trophies entry on line 64 (issue 54 in the old repository) is left as it is, since I could not find that issue in the new repository.
Checked against
shell-quote: repositoryljharb/shell-quote.git ls-remoteonljharb/shell-quote: tagsv1.7.2andv1.7.3exist.Testing
I did not run
docker buildfor the PoC. The change swaps the clone source and pins a tag that exists.Tausif Ahmed, Founder & CEO, Purplecop Security