Skip to content

SystemSan: shell-quote repository moved from substack/node-shell-quote to ljharb/shell-quote - #16554

Open
tausif-ahmed-guardian wants to merge 1 commit into
google:masterfrom
tausif-ahmed-guardian:gitty/oss-fuzz-systemsan-shell-quote-moved
Open

tausif-ahmed-guardian wants to merge 1 commit into
google:masterfrom
tausif-ahmed-guardian:gitty/oss-fuzz-systemsan-shell-quote-moved

Conversation

@tausif-ahmed-guardian

Copy link
Copy Markdown

Summary

The SystemSan shell-quote PoC no longer builds, because it clones https://github.com/substack/node-shell-quote.git, which does not exist any more (git ls-remote reports "Repository not found"). The npm registry lists the project's repository as https://github.com/ljharb/shell-quote.

Change

  • infra/experimental/SystemSan/PoEs/node-shell-quote-v1.7.3/Dockerfile: clone ljharb/shell-quote at tag v1.7.3 into the same node-shell-quote directory, so build.sh (npm install ./node-shell-quote/) is unchanged. The tag is pinned because the old clone took the latest commit, which was v1.7.3 at the time. The new repository's default branch is a later release, so an unpinned clone would no longer test v1.7.3.
  • infra/experimental/SystemSan/README.md lines 51 and 55: point the two links at ljharb/shell-quote.

The Trophies entry on line 64 (issue 54 in the old repository) is left as it is, since I could not find that issue in the new repository.

Checked against

  • npm registry metadata for shell-quote: repository ljharb/shell-quote.
  • git ls-remote on ljharb/shell-quote: tags v1.7.2 and v1.7.3 exist.

Testing

I did not run docker build for the PoC. The change swaps the clone source and pins a tag that exists.

Tausif Ahmed, Founder & CEO, Purplecop Security

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant