Skip to content

[clickhouse] Restore daily fuzz builds and target packaging - #16438

Open
motsc wants to merge 5 commits into
google:masterfrom
motsc:clusterfuzz-clickhouse-adapter-public
Open

motsc wants to merge 5 commits into
google:masterfrom
motsc:clusterfuzz-clickhouse-adapter-public

Conversation

@motsc

@motsc motsc commented Nov 3, 2026 •

Copy link
Copy Markdown

Summary

  • Discover the _fuzzer.cpp targets actually defined by the configured ClickHouse build, build the complete set for daily OSS-Fuzz jobs, and retain a two-target cap only when OSS_FUZZ_CI=1 is explicitly set.
  • Replace previous project output, then package each selected binary with its options, dictionary, and deterministic committed or generated seed corpus.
  • Install ClickHouse's pinned Rust toolchain with rust-src, add the required assembler dependency, and stage the exact source files referenced by coverage mappings.
  • Add compiler-backed build-script contract tests, a restricted test workflow, and project documentation for local and hosted verification.

Fuzz Introspector changes are not part of this PR.

Evidence

  • Six non-coverage compiler-backed contract tests pass on Ubuntu Linux. The new cases prove OSS_FUZZ_CI=0 keeps the full target set and a capped build removes outputs left by a previous full build.
  • Ubuntu 24.04 with LLVM 18 reproduces the coverage test's unsupported --empty-profile failure. The workflow is pinned to the generally available Ubuntu 26.04 runner, whose unversioned LLVM is 21, and explicitly installs its compiler-rt development package.
  • py_compile, bash -n, shellcheck, and git diff --check pass.
  • The coverage-staging regression test fails on the old behavior and passes after the repair when the same workspace is reused.
  • The exact adapter plus companion ClickHouse prerequisite passed official build_fuzzers --clean and check_build for address, memory, and undefined sanitizers, producing 71-file output manifests per sanitizer and passing direct seed replay and mutation smoke checks.
  • Five independent read-only reviews found the issues corrected by this revision and no public-safety issue.
  • The complete five-file patch SHA-256 is 0705ac0c192ac2b97be7bd1606999dad68db130386e3acad061fcf9fa6125ba5.

ClickHouse/ClickHouse#129054 must merge first, and the OSS-Fuzz project image must then be rebuilt from a ClickHouse revision containing it before this adapter is activated. The dependency is full MSan and coverage compilation/linkage compatibility. This adapter packages committed seed directories directly from the ClickHouse source tree; seed delivery does not depend on ClickHouse's native aggregate-target packaging script.

@google-cla

google-cla Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

motsc is a new contributor to projects/clickhouse. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, nickitat, Felixoid, evillique, CurtizJ, nikitamikhaylov, kitaisreal, blinkov, qoega, kyprizel

@motsc
motsc force-pushed the clusterfuzz-clickhouse-adapter-public branch from 4ffb6c9 to 5e2e293 Compare November 4, 2026 17:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant