Skip to content

coverage: don't fail the build when a corpus backup is missing - #16423

Open
ligurio wants to merge 1 commit into
google:masterfrom
ligurio:ligurio/gh-xxxx-fix-broken-cov
Open

ligurio wants to merge 1 commit into
google:masterfrom
ligurio:ligurio/gh-xxxx-fix-broken-cov

Conversation

@ligurio

@ligurio ligurio commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

A coverage build downloads corpus backups for every fuzz target of the project and unpacks them before running the coverage script. When a backup is missing (for example, because corpus pruning does not finish for that fuzz target), wget leaves an empty archive, unzip fails and the whole coverage build is reported as failed. Note that the old exit 1 was inside a subshell, so it never aborted the loop: whether the coverage script ran at all depended on the last file in the glob.

This is what happens to lua and tarantool right now: 88 and 100 fuzz targets, respectively, have no corpus backup, so their coverage reports have not been generated since April 2026 and February 2026.

Log a warning instead and always run the coverage script. Fuzz targets without a corpus are simply absent from the report, while a failure of the coverage script itself still fails the build.

Follows up #14859
Relates to #13390
Relates to #13263

@ligurio ligurio mentioned this pull request Nov 2, 2026
34 of 39 tasks
@ligurio

ligurio commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@ligurio
ligurio force-pushed the ligurio/gh-xxxx-fix-broken-cov branch 2 times, most recently from 6c3262f to 54b0e08 Compare November 9, 2026 18:31
A coverage build downloads corpus backups for every fuzz target of
the project and unpacks them before running the coverage script.
When a backup is missing (for example, because corpus pruning does
not finish for that fuzz target), wget leaves an empty archive,
unzip fails and the whole coverage build is reported as failed.
Note that the old `exit 1` was inside a subshell, so it never
aborted the loop: whether the coverage script ran at all depended
on the last file in the glob.

This is what happens to lua and tarantool right now: 88 and 100
fuzz targets, respectively, have no corpus backup, so their
coverage reports have not been generated since April 2026 and
February 2026.

Log a warning instead and always run the coverage script. Fuzz
targets without a corpus are simply absent from the report, while
a failure of the coverage script itself still fails the build.

Follows up google#14859
@ligurio
ligurio force-pushed the ligurio/gh-xxxx-fix-broken-cov branch from 54b0e08 to a25f7e2 Compare November 17, 2026 06:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant