Repository navigation
Conversation
34 of 39 tasks
Contributor
Author
|
ligurio
force-pushed
the
ligurio/gh-xxxx-fix-broken-cov
branch
2 times, most recently
from
November 9, 2026 18:31
6c3262f to
54b0e08
Compare
A coverage build downloads corpus backups for every fuzz target of the project and unpacks them before running the coverage script. When a backup is missing (for example, because corpus pruning does not finish for that fuzz target), wget leaves an empty archive, unzip fails and the whole coverage build is reported as failed. Note that the old `exit 1` was inside a subshell, so it never aborted the loop: whether the coverage script ran at all depended on the last file in the glob. This is what happens to lua and tarantool right now: 88 and 100 fuzz targets, respectively, have no corpus backup, so their coverage reports have not been generated since April 2026 and February 2026. Log a warning instead and always run the coverage script. Fuzz targets without a corpus are simply absent from the report, while a failure of the coverage script itself still fails the build. Follows up google#14859
ligurio
force-pushed
the
ligurio/gh-xxxx-fix-broken-cov
branch
from
November 17, 2026 06:10
54b0e08 to
a25f7e2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A coverage build downloads corpus backups for every fuzz target of the project and unpacks them before running the coverage script. When a backup is missing (for example, because corpus pruning does not finish for that fuzz target), wget leaves an empty archive, unzip fails and the whole coverage build is reported as failed. Note that the old
exit 1was inside a subshell, so it never aborted the loop: whether the coverage script ran at all depended on the last file in the glob.This is what happens to lua and tarantool right now: 88 and 100 fuzz targets, respectively, have no corpus backup, so their coverage reports have not been generated since April 2026 and February 2026.
Log a warning instead and always run the coverage script. Fuzz targets without a corpus are simply absent from the report, while a failure of the coverage script itself still fails the build.
Follows up #14859
Relates to #13390
Relates to #13263