Skip to content

Fix incorrect timing of the "RPC request sent" log. #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhaoli merged 1 commit into from
Jan 15, 2026
+1 −1
Merged

Fix incorrect timing of the "RPC request sent" log. #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mobly/controllers/android_device_lib/snippet_client_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,7 @@ def _client_send(self, message):
try:
self._client.write(f'{message}\n'.encode('utf8'))
self._client.flush()
self.log.debug('RPC request sent.')
except socket.error as e:
raise errors.Error(
self._device,
Expand Down
1 change: 0 additions & 1 deletion mobly/snippet/client_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ def _rpc(self, rpc_func_name, *args, **kwargs):

self.log.debug('Sending RPC request %s.', request)
response = self.send_rpc_request(request)
self.log.debug('RPC request sent.')

if self.verbose_logging or _MAX_RPC_RESP_LOGGING_LENGTH >= len(response):
self.log.debug('Snippet received: %s', response)
Expand Down
Loading