This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Open
Conversation
ericchiang
reviewed
Jun 28, 2022
Contributor
Author
|
@ericchiang |
ericchiang
reviewed
Jun 29, 2022
Contributor
|
Thanks! mostly just a comment about creating a new directory vs not |
Contributor
Author
|
Done |
Contributor
|
also, can you please squash your commits? |
Contributor
Author
|
@ericchiang I was squashing commits and the PR seemed to be closed |
Contributor
|
It looks like you've got some conflicts? If you need to open a new PR feel free, or I can pull in the changes myself. |
Contributor
Author
|
If it's not too much of a problem, I'll leave it to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JARs backup at the time of running the inspection on the jar files, either a scan or with the --rewrite command, for example
the copy of the JARs is saved in
backup/*.jarThis may solve the issues:
Any improvement will be a pleasure to carry it out