htool_console: Reconnect USB on failure#224
Open
wak-google wants to merge 2 commits intogoogle:mainfrom
Open
Conversation
wak-google
force-pushed
the
console-retry
branch
from
ad1e13c to
31c150b
Compare
We usually don't want to kill the console logger with an error when a USB failure occurs. Instead, we want to try reconnecting in a loop until the device comes back. This allows us to retain the console pointer around platform resets that cause USB disconnections and prevents our services streaming these logs from sending duplicate messages.
wak-google
force-pushed
the
console-retry
branch
from
08da46f to
e9a6492
Compare
It's possible that if the console is disconnected long enough we can experience jumps in the console data because the buffer on the RoT side was not big enough for our time lapse. Log any time this happens so we can understand how much context we lost if any.
wak-google
force-pushed
the
console-retry
branch
from
e9a6492 to
5f50277
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We usually don't want to kill the console logger with an error when a USB failure occurs. Instead, we want to try reconnecting in a loop until the device comes back. This allows us to retain the console pointer around platform resets that cause USB disconnections and prevents our services streaming these logs from sending duplicate messages.