Fix integer overflow in DecodeEntry bounds check#1323
Open
M0oo0ry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bounds check in DecodeEntry() compares
limit - pagainst*non_shared + *value_length. Both operands of the addition areuint32_t, so the sum can wrap around when their combined value
exceeds UINT32_MAX. When that happens the comparison passes
incorrectly and the function returns a pointer that may be past
limit, which callers then dereference during block iteration.This change widens the comparison to uint64_t so the addition cannot
wrap. Behavior on valid blocks is unchanged.
Tested:
env_posix_test).