Repository navigation
Conversation
Decouple resolution and processing from the concrete context before introducing a no-op implementation. Preserve lookup tracing for google#3019. Refs google#3028
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the first step requested in #3028 (comment):
IncrementalContextfor lifecycle, dirty-file calculation, output/cache updates, and lookup recording.IncrementalContextBaseimplement the contract, with AA-specific operations supplied byIncrementalContextAA.dumpLookupRecordson the contract for existing test/debug consumers rather than coupling them back to AA. Its replacement remains separate work under Tests depending onIncrementalContextAA.dumpLookupRecords#3019.recordLookupForGetAllis now an interface override instead of an internal concrete-class method.This is a behavior-preserving prerequisite refactor. It does not introduce the no-op context or change the incremental guards, resolver globals, or logging design. #3028 stays open for those follow-ups.
Validation
./gradlew :kotlin-analysis-api:test --tests '*IncrementalContextTest' --tests '*testRecordJava*': 27 tests passed, including existing lookup-recording coverage in all four configurations../gradlew :kotlin-analysis-api:test: 659 passed, 8 skipped, 0 failures/errors.git diff --checkRefs #3028