Repository navigation
Conversation
getDeclarationsInSourceOrder restores source order for KOTLIN_LIB containers by matching members against the container's class file. For classes nested inside another class, the resolved class file is the outermost enclosing class's, so the ordering comes out wrong. Reproduces google#2617.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
CLA signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only PR for #2617, following the bug contribution workflow from CONTRIBUTING.md (failing test first, fix in a follow-up).
getDeclarationsInSourceOrdersortsKOTLIN_LIBmembers against the member order recorded in the container's class file. When the container is a class nested inside another class the wrong class file gets used, so for example an annotation class declared inside an object comes back as[<init>, b, a, c]instead of[a, b, c, <init>], while a top-level annotation class right next to it is ordered correctly.The new test data declares a top-level annotation class and one nested inside an object in a lib module, plus copies in the source module for comparison, and the suite entry uses
runFailingTestso it passes while the bug is present.Happy to reshape the test if there's a preferred way to cover this.