Repository navigation
Conversation
jaschdoc
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a minor comment. Have you also tried this on native backends? There is a directive: TARGET_BACKEND and WITH_FIXED_TARGET. See the test native/packageDeclarations.kt for an example.
Add Native coverage requested in review.
|
@jaschdoc Addressed the processor parameterization comment and added Native coverage as requested. All 8 JVM/Native × AA/PSI × feature-flag cases passed locally. Could you please review the updated PR again? Thank you! |
…tation-source-order # Conflicts: # kotlin-analysis-api/src/test/kotlin/com/google/devtools/ksp/test/KSPUnitTestSuite.kt
|
Also merged the latest main and resolved the test-suite conflict, retaining both tests. Re-ran the focused JVM and Native tests afterward: all 8 configurations pass. The branch is now updated for re-review. |
|
@jaschdoc Could you please re-review this PR? The processor now uses PROCESSOR INPUT, Native coverage has been added, and the conflict with main is resolved. All 8 focused test configurations pass. Thank you! |
Summary
PROCESSOR INPUT, as requested in review.getDeclarationsInSourceOrderpreserves constructor parameter order for top-level and nested annotations on JVM and Native (TARGET_BACKEND: NATIVE,WITH_FIXED_TARGET: linux_x64).Testing
./gradlew :kotlin-analysis-api:cleanTest :kotlin-analysis-api:test --tests '*testNestedAnnotationDeclarationOrder' --tests '*testNativeNestedAnnotationDeclarationOrder'All 8 JVM/Native × AA/PSI × current/new-feature cases passed.
Closes #2617