Feature/upstream curve fixes - #21
Merged
Merged
Conversation
USD widths represent diameter, whereas Mitsuba curve control points expect radius. This change applies the 0.5 factor to properly handle curve sizes.
Change UsdGeom.BasisCurves to UsdGeom.Curves in convert_to_mitsuba and _convert_curves to support both BasisCurves and NurbsCurves. Detect bsplinecurve based on type and basis attributes or NurbsCurves class.
dvicini
self-requested a review
July 31, 2026 08:27
dvicini
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I'm sending my changes upstream :)