Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ public boolean remove(Object o) {
return delegate.remove(o);
}

@Override
protected void removeRange(int fromIndex, int toIndex) {
delegate.subList(fromIndex, toIndex).clear();
}

@Override
public boolean removeAll(Collection<?> c) {
return delegate.removeAll(c);
Expand Down
41 changes: 41 additions & 0 deletions gson/src/test/java/com/google/gson/JsonArrayAsListTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,47 @@ public void testClear() {
assertThat(a).hasSize(0);
}

@Test
public void testSubListClear() {
JsonArray a = new JsonArray();
for (int i = 0; i < 6; i++) {
a.add(i);
}

List<JsonElement> list = a.asList();
List<JsonElement> subList = list.subList(1, 5);
subList.clear();

assertThat(subList).isEmpty();
assertThat(list).containsExactly(new JsonPrimitive(0), new JsonPrimitive(5)).inOrder();
assertThat(a.toString()).isEqualTo("[0,5]");

subList.add(new JsonPrimitive(7));
assertThat(a.toString()).isEqualTo("[0,7,5]");
}

@Test
public void testNestedSubListClear() {
JsonArray a = new JsonArray();
for (int i = 0; i < 6; i++) {
a.add(i);
}

List<JsonElement> list = a.asList();
List<JsonElement> subList = list.subList(1, 5);
subList.subList(1, 3).clear();

assertThat(subList).containsExactly(new JsonPrimitive(1), new JsonPrimitive(4)).inOrder();
assertThat(list)
.containsExactly(
new JsonPrimitive(0), new JsonPrimitive(1), new JsonPrimitive(4), new JsonPrimitive(5))
.inOrder();
assertThat(a.toString()).isEqualTo("[0,1,4,5]");

subList.subList(1, 1).clear();
assertThat(a.toString()).isEqualTo("[0,1,4,5]");
}

@Test
public void testRemoveIf() {
JsonArray a = new JsonArray();
Expand Down
Loading