Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stats._iter_weakref_registrykeeps aHashableWeakReffor every output iterator, and those refs hash and compare by the referent'sid(). Nothing removes a ref when the iterator is collected, so dead entries pile up. CPython reuses those addresses,set.addtreats the new iterator as the stale entry, and the live iterator is never registered.HashableWeakRefnow discards its registry entry when the referent is collected, and a dead ref no longer compares equal to a live iterator at the same address.The new test creates and drops iterators in a loop. It fails on current main and passes with this change:
Fixes #1427
📚 Documentation preview 📚: https://google-grain--1429.org.readthedocs.build/