vk: set the renderpass name when DebugUtils is on#10214
Merged
Conversation
poweifeng
commented
Jul 16, 2026
poweifeng
commented
Contributor
- This PR also enables DebugUtils by default on debug builds. (when to enable it will be re-visited).
- Separated validation from DebugUtils so that they are not tied together in enablement.
- Together with Android Performance Analyzer, you should be able to see named renderpasses in the GPU non-fragment, fragment workload on the timeline.
poweifeng
requested review from
anishmgoyal,
jorgeag-google,
phoenixxxx,
pixelflinger and
rafadevai
and removed request for
pixelflinger
July 16, 2026 23:55
pixelflinger
approved these changes
Jul 17, 2026
rafadevai
reviewed
Jul 17, 2026
| #include "VulkanAsyncHandles.h" | ||
|
|
||
| #include "VulkanConstants.h" | ||
| #include "VulkanDriver.h" |
Contributor
There was a problem hiding this comment.
why do we need to include this here?
Contributor
Author
There was a problem hiding this comment.
there's a reference in line 165. Only compiled when FVK_DEBUG_DEBUG_UTILS is enabled.
rafadevai
reviewed
Jul 17, 2026
| // Assign a label to the framebuffer for debugging purposes. | ||
| #if FVK_ENABLED(FVK_DEBUG_GROUP_MARKERS | FVK_DEBUG_DEBUG_UTILS) | ||
| auto const topMarker = mCommands.getTopGroupMarker(); | ||
| uint64_t fbVk = (uint64_t) vkfb->getVkFramebuffer(); |
Contributor
There was a problem hiding this comment.
put them inside the if block
rafadevai
approved these changes
Jul 17, 2026
anishmgoyal
approved these changes
Jul 17, 2026
| #endif // FVK_ENABLED(FVK_DEBUG_VALIDATION) | ||
|
|
||
| #if FVK_ENABLED(FVK_DEBUG_DEBUG_UTILS) | ||
| #if FVK_ENABLED(FVK_DEBUG_DEBUG_UTILS) && FVK_ENABLED(FVK_DEBUG_VALIDATION) |
Contributor
There was a problem hiding this comment.
could we just check the validation flag?
Contributor
Author
There was a problem hiding this comment.
they are independent. You could have one without the other.
poweifeng
enabled auto-merge (squash)
July 17, 2026 21:57
poweifeng
force-pushed
the
pf/vk-fix-validation-enable
branch
from
July 17, 2026 22:15
e2256da to
1bb539b
Compare
poweifeng
disabled auto-merge
July 17, 2026 22:48
- This PR also enables DebugUtils by default on debug builds. (when to enable it will be re-visited). - Separated validation from DebugUtils so that they are not tied together in enablement. - Together with Android Performance Analyzer, you should be able to see named renderpasses in the GPU non-fragment, fragment workload on the timeline.
poweifeng
force-pushed
the
pf/vk-fix-validation-enable
branch
from
July 17, 2026 23:17
1bb539b to
81dabd7
Compare
pixelflinger
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.