Adds an extra command pool field in vkCommands#10203
Open
jorgeag-google wants to merge 1 commit into
Open
Conversation
jorgeag-google
force-pushed
the
async_cmndpool
branch
from
July 13, 2026 21:13
fb91854 to
d89125c
Compare
rafadevai
reviewed
Jul 14, 2026
| VulkanCommands::VulkanCommands(VkDevice device, VkQueue queue, uint32_t queueFamilyIndex, | ||
| VkQueue protectedQueue, uint32_t protectedQueueFamilyIndex, VulkanContext const& context, | ||
| VkQueue protectedQueue, uint32_t protectedQueueFamilyIndex, | ||
| std::unique_ptr<CommandBufferPool> asyncPool, VulkanContext const& context, |
Contributor
There was a problem hiding this comment.
this seems the wrong approach to me. Its strange to pass down one pool but then internally it creates one. Also what about the mSemaphoreManager.
In this case for the async, accessing the semaphore manager is that thread safe?
Contributor
Author
There was a problem hiding this comment.
I changed the constructor. I am thinkinng if the semaphore manager needs to be thread safe. I know it is referenced in the command pool
This add an extra command pool to the vKCommands struct that will be used for the async work. This is the first step to make the async commands in the VK backend really asynchronous.
jorgeag-google
force-pushed
the
async_cmndpool
branch
from
July 14, 2026 20:52
d89125c to
5ca10e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add an extra command pool to the vKCommands struct that will be used for the async work.
This is the first step to make the async commands in the VK backend really asynchronous.