Repository navigation
docs: remove hard-coded private IPs and fix the agent gateway hostname - #236
Merged
Merged
Conversation
Replace the entry point, partner and Agent Gateway IP literals in the README, docs and llms.txt with the layer-2 output that reports the entry point VIP (esmeralda status --unit layer-2-networking --output entrypoint_address). partner.esmeralda.internal is a host rule on the same VIP, and the Agent Gateway is Google-managed and enters the VPC through its PSC attachment, so neither has its own address. Fix the specialist hostname in the capability governance page, drop the stale internal.gateway zone note and the nonexistent partner forwarding rule. Add tests/guards/test_docs_private_ips.py, which fails on private IPv4 literals in docs, with an allowlist for the subnet CIDRs and the SWP address that the networking module sets. Closes #193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README, several docs pages and
llms.txthard-coded private IPs for the entry point, the partner front door and the Central Agent Gateway. None of them matched what Terraform creates:entrypoint_ip_addresspins it.partner.esmeralda.internalis a host rule on that same VIP; there is no separate partner IP or forwarding rule.agw-egress-na-<env>.Changes:
<entrypoint-ip>or a description. Point to the layer-2 output that reports the VIP:uv run esmeralda status --env <env> --unit layer-2-networking --output entrypoint_address.*.esmeralda.internal, as configured in the connectivity template's DNS peering).ilb-esmeralda-rule-<env>. Drop the staleinternal.gateway.zone note.infrastructure/modules/2-networking/main.tf.tests/guards/test_docs_private_ips.py(runs inmake test-guards). It fails on private IPv4 literals in tracked Markdown anddocs/. A small allowlist covers the subnet CIDRs and the SWP address; each entry names its source file and reason, and is checked to still be set there and still be cited.Testing:
make test-guards,make docs-build(strict) andmake testpass. Docs and a static guard only, so no dev deployment test is needed.Closes #193